search

hughsie / colord

Making color management just work
GNU General Public License v2.0
75 stars 51 forks source link

colord fails to build if libgusb was built without gobject-introspection support #90

Open tgurr opened 5 years ago

tgurr commented 5 years ago

Since it's last release libgusb can be built without gobject-introspection support again, that feature was lost with the translation to the meson build system. The same is true for colord which before the migration to meson also allowed to be built without gobject-introspection via a configure flag.

[59/192] /usr/bin/g-ir-scanner -pthread -I/usr/x86_64-pc-linux-gnu/include/gobject-introspection-1.0 -I/usr/x86_64-pc-linux-gnu/lib/libffi-3.2.1/include -I/usr/x86_64-pc-linux-gnu/include/glib-2.0 -I/usr/x86_64-pc-linux-gnu/lib/glib-2.0/include --no-libtool --namespace=Colorhug --nsversion=1.0 --warn-all --output lib/colorhug/Colorhug-1.0.gir -I/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/colord-1.4.3/lib/colorhug -I/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colorhug -I./lib/colord/. -I../colord-1.4.3/lib/colord/. -I./lib/. -I../colord-1.4.3/lib/. -I./. -I../colord-1.4.3/. --filelist=/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colorhug/f86f99c@@colorhug@sha/Colorhug_1.0_gir_filelist -L/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colorhug -L/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colord --extra-library=colorhug --include=Gio-2.0 --include=GObject-2.0 --include=GUsb-1.0 --include-uninstalled=lib/colord/Colord-1.0.gir --symbol-prefix=ch --identifier-prefix=Ch --pkg-export=colorhug --cflags-begin -fstack-protector-strong -Waggregate-return -Wunused -Warray-bounds -Wcast-align -Wclobbered -Wdeclaration-after-statement -Wempty-body -Wextra -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-signedness -Wignored-qualifiers -Wimplicit-function-declaration -Winit-self -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wmissing-parameter-type -Wmissing-prototypes -Wnested-externs -Wno-discarded-qualifiers -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-suggest-attribute=format -Wno-unused-parameter -Wold-style-definition -Woverride-init -Wpointer-arith -Wreturn-type -Wshadow -Wsign-compare -Wstrict-aliasing -Wstrict-prototypes -Wswitch-default -Wtype-limits -Wundef -Wuninitialized -Wunused-but-set-variable -Wwrite-strings -DCD_COMPILATION -D_XOPEN_SOURCE=700 -I./lib/colord/. -I../colord-1.4.3/lib/colord/. -I./lib/. -I../colord-1.4.3/lib/. -I./. -I../colord-1.4.3/. -I/usr/x86_64-pc-linux-gnu/include/gio-unix-2.0 -I/usr/x86_64-pc-linux-gnu/include/libmount -I/usr/x86_64-pc-linux-gnu/include/blkid -I/usr/x86_64-pc-linux-gnu/include/uuid -I/usr/x86_64-pc-linux-gnu/lib/libffi-3.2.1/include -I/usr/x86_64-pc-linux-gnu/include/glib-2.0 -I/usr/x86_64-pc-linux-gnu/lib/glib-2.0/include -I/usr/x86_64-pc-linux-gnu/include/gusb-1 -I/usr/x86_64-pc-linux-gnu/include/libusb-1.0 --cflags-end --add-include-path=/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colord -L/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colord --library colorhug -L/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colorhug --extra-library=gio-2.0 --extra-library=gobject-2.0 --extra-library=glib-2.0 --extra-library=gusb --extra-library=usb-1.0 --extra-library=lcms2 --extra-library=m --extra-library=udev
FAILED: lib/colorhug/Colorhug-1.0.gir 
/usr/bin/g-ir-scanner -pthread -I/usr/x86_64-pc-linux-gnu/include/gobject-introspection-1.0 -I/usr/x86_64-pc-linux-gnu/lib/libffi-3.2.1/include -I/usr/x86_64-pc-linux-gnu/include/glib-2.0 -I/usr/x86_64-pc-linux-gnu/lib/glib-2.0/include --no-libtool --namespace=Colorhug --nsversion=1.0 --warn-all --output lib/colorhug/Colorhug-1.0.gir -I/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/colord-1.4.3/lib/colorhug -I/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colorhug -I./lib/colord/. -I../colord-1.4.3/lib/colord/. -I./lib/. -I../colord-1.4.3/lib/. -I./. -I../colord-1.4.3/. --filelist=/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colorhug/f86f99c@@colorhug@sha/Colorhug_1.0_gir_filelist -L/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colorhug -L/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colord --extra-library=colorhug --include=Gio-2.0 --include=GObject-2.0 --include=GUsb-1.0 --include-uninstalled=lib/colord/Colord-1.0.gir --symbol-prefix=ch --identifier-prefix=Ch --pkg-export=colorhug --cflags-begin -fstack-protector-strong -Waggregate-return -Wunused -Warray-bounds -Wcast-align -Wclobbered -Wdeclaration-after-statement -Wempty-body -Wextra -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-signedness -Wignored-qualifiers -Wimplicit-function-declaration -Winit-self -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wmissing-parameter-type -Wmissing-prototypes -Wnested-externs -Wno-discarded-qualifiers -Wno-missing-field-initializers -Wno-strict-aliasing -Wno-suggest-attribute=format -Wno-unused-parameter -Wold-style-definition -Woverride-init -Wpointer-arith -Wreturn-type -Wshadow -Wsign-compare -Wstrict-aliasing -Wstrict-prototypes -Wswitch-default -Wtype-limits -Wundef -Wuninitialized -Wunused-but-set-variable -Wwrite-strings -DCD_COMPILATION -D_XOPEN_SOURCE=700 -I./lib/colord/. -I../colord-1.4.3/lib/colord/. -I./lib/. -I../colord-1.4.3/lib/. -I./. -I../colord-1.4.3/. -I/usr/x86_64-pc-linux-gnu/include/gio-unix-2.0 -I/usr/x86_64-pc-linux-gnu/include/libmount -I/usr/x86_64-pc-linux-gnu/include/blkid -I/usr/x86_64-pc-linux-gnu/include/uuid -I/usr/x86_64-pc-linux-gnu/lib/libffi-3.2.1/include -I/usr/x86_64-pc-linux-gnu/include/glib-2.0 -I/usr/x86_64-pc-linux-gnu/lib/glib-2.0/include -I/usr/x86_64-pc-linux-gnu/include/gusb-1 -I/usr/x86_64-pc-linux-gnu/include/libusb-1.0 --cflags-end --add-include-path=/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colord -L/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colord --library colorhug -L/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colorhug --extra-library=gio-2.0 --extra-library=gobject-2.0 --extra-library=glib-2.0 --extra-library=gusb --extra-library=usb-1.0 --extra-library=lcms2 --extra-library=m --extra-library=udev
Couldn't find include 'GUsb-1.0.gir' (search path: '['/var/tmp/paludis/build/sys-apps-colord-1.4.3/work/_build/lib/colord', '/usr/share/gir-1.0', '/usr/share/gir-1.0', '/usr/share/gir-1.0', '/usr/share/gir-1.0', '/usr/share/gir-1.0']')
ninja: build stopped: subcommand failed.

It would be nice if a build option for gobject-introspection support could be added to the meson build again for colord as well.

hughsie commented 5 years ago

If you do a PR I'd gladly merge it.