hughsie / colord

Making color management just work
GNU General Public License v2.0
75 stars 51 forks source link

1.4.4: test suite is failing #97

Closed kloczek closed 10 months ago

kloczek commented 5 years ago
+ /usr/bin/meson test -C x86_64-redhat-linux-gnu --num-processes 48 --print-errorlogs
ninja: Entering directory `/home/tkloczko/rpmbuild/BUILD/colord-1.4.4/x86_64-redhat-linux-gnu'
ninja: no work to do.
1/4 colord-test-private                     OK       6.60 s 
2/4 colord-test-daemon                      FAIL     0.48 s (killed by signal 6 SIGABRT)
3/4 colorhug-self-test                      OK       0.08 s 
4/4 cd-self-test                            OK       0.04 s 

Ok:                    3
Expected Fail:         0
Fail:                  1
Unexpected Pass:       0
Skipped:               0
Timeout:               0

The output from the failed tests:

2/4 colord-test-daemon                      FAIL     0.48 s (killed by signal 6 SIGABRT)

--- command ---
/home/tkloczko/rpmbuild/BUILD/colord-1.4.4/x86_64-redhat-linux-gnu/lib/colord/colord-test-daemon
--- stdout ---
# random seed: R02S28c72340166128d72fe169c8ff072d6e
1..24
# Start of colord tests
ok 1 /colord/client
# libcolord-DEBUG: using random key a09d
Bail out! libcolord:ERROR:../lib/colord/cd-test-daemon.c:1873:colord_device_func: assertion failed (error == NULL): failed to obtain org.freedesktop.color-manager.create-device auth (cd_client_error, 2)
--- stderr ---
**
libcolord:ERROR:../lib/colord/cd-test-daemon.c:1873:colord_device_func: assertion failed (error == NULL): failed to obtain org.freedesktop.color-manager.create-device auth (cd_client_error, 2)
-------

Full log written to /home/tkloczko/rpmbuild/BUILD/colord-1.4.4/x86_64-redhat-linux-gnu/meson-logs/testlog.txt
error: Bad exit status from /var/tmp/rpm-tmp.UKwCRa (%check)
Apteryks commented 2 years ago

There is still a problem, where colord-test-private fails instead of being skipped like colord-test-daemon:

starting phase `check'
ninja: Entering directory `/tmp/guix-build-colord-minimal-1.4.6.drv-0/build'
ninja: no work to do.
1/4 colord-test-private FAIL            3.20s   killed by signal 6 SIGABRT
>>> MALLOC_PERTURB_=3 TESTDATADIR=/tmp/guix-build-colord-minimal-1.4.6.drv-0/colord-1.4.6/data/tests /tmp/guix-build-colord-minimal-1.4.6.drv-0/build/lib/colord/colord-test-private
――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
Listing only the last 100 lines from a long log.
# tag 09:
#   sig 'bTRC' [0x62545243]
#   link        'gTRC' [0x67545243]
# tag 10:
#   sig 'chrm' [0x6368726d]
#   size        36
#   type        'chrm' [0x6368726d]
# '
** (/tmp/guix-build-colord-minimal-1.4.6.drv-0/build/lib/colord/colord-test-private:1033): DEBUG: 15:50:24.375: CdIcc: 'icc:
Header:
  Size          = 8760 bytes
  Version       = 4.0
  Profile Kind  = display-device
  Colorspace    = rgb
  Conn. Space   = xyz
  Date, Time    = 2013-03-25, 17:00:11
  Flags         = Not embedded profile, Use anywhere
  Dev. Attrbts  = reflective, glossy
  Rndrng Intnt  = perceptual
  Creator       = lcms
  Profile ID    = 1123bd7c69c72f64f01b0f4591a420d4
tag 00:
  sig   'desc' [0x64657363]
  size  98
  type  'mluc' [0x6d6c7563]
Text:
  en_GB:        Crayon Colours [64 bytes]
  en_US:        Crayon Colors [60 bytes]

tag 01:
  sig   'cprt' [0x63707274]
  size  32
  type  'mluc' [0x6d6c7563]
Text:
  en_US:          [12 bytes]

tag 02:
  sig   'wtpt' [0x77747074]
  size  20
  type  'XYZ ' [0x58595a20]
XYZ:
  X:0.964203 Y:1.000000 Z:0.824905

tag 03:
  sig   'chad' [0x63686164]
  size  44
  type  'sf32' [0x73663332]

tag 04:
  sig   'rXYZ' [0x7258595a]
  size  20
  type  'XYZ ' [0x58595a20]
XYZ:
  X:0.435852 Y:0.222382 Z:0.013916

tag 05:
  sig   'bXYZ' [0x6258595a]
  size  20
  type  'XYZ ' [0x58595a20]
XYZ:
  X:0.143021 Y:0.060593 Z:0.713837

tag 06:
  sig   'gXYZ' [0x6758595a]
  size  20
  type  'XYZ ' [0x58595a20]
XYZ:
  X:0.385330 Y:0.717041 Z:0.097137

tag 07:
  sig   'rTRC' [0x72545243]
  size  8204
  type  'curv' [0x63757276]
Curve:

tag 08:
  sig   'gTRC' [0x67545243]
  link  'rTRC' [0x72545243]
tag 09:
  sig   'bTRC' [0x62545243]
  link  'gTRC' [0x67545243]
tag 10:
  sig   'chrm' [0x6368726d]
  size  36
  type  'chrm' [0x6368726d]
'
ok 9 /colord/icc{localized}
ok 10 /colord/icc{edid}
ok 11 /colord/icc{characterization}
ok 12 /colord/icc{save}
ok 13 /colord/icc{empty}
ok 14 /colord/icc{corrupt-dict}
ok 15 /colord/icc{clear}
ok 16 /colord/icc{tags}
# libcolord-DEBUG: Incorrect content type for /tmp/colord-yshl/already-exists.icc, got application/x-zerosize
(/tmp/guix-build-colord-minimal-1.4.6.drv-0/build/lib/colord/colord-test-private:1033): libcolord-DEBUG: 15:50:24.382: Incorrect content type for /tmp/colord-yshl/already-exists.icc, got application/x-zerosize
Bail out! ERROR:../colord-1.4.6/lib/colord/cd-test-private.c:2032:colord_icc_store_func: assertion failed (added == 1): (0 == 1)
stderr:
**
ERROR:../colord-1.4.6/lib/colord/cd-test-private.c:2032:colord_icc_store_func: assertion failed (added == 1): (0 == 1)
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

2/4 colord-test-daemon  SKIP            0.02s   exit status 77
3/4 colorhug-self-test  OK              0.03s
4/4 cd-self-test        OK              0.10s

Summary of Failures:

1/4 colord-test-private FAIL            3.20s   killed by signal 6 SIGABRT

Ok:                 2   
Expected Fail:      0   
Fail:               1   
Unexpected Pass:    0   
Skipped:            1   
Timeout:            0   

Full log written to /tmp/guix-build-colord-minimal-1.4.6.drv-0/build/meson-logs/testlog.txt
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "meson" arguments: ("test" "--print-errorlogs" "-t" "0") exit-status: 1 term-signal: #f stop-signal: #f> 
phase `check' failed after 4.1 seconds

I've disabled the test like so in GNU Guix for now:

(add-after 'unpack 'disable-problematic-tests
            (lambda _
              ;; Skip the colord-test-private, which requires a *system* D-Bus
              ;; session, which wants to run as root, among other
              ;; requirements.
              (substitute* "lib/colord/meson.build"
                ((".*test\\('colord-test-private'.*") ""))))
kloczek commented 10 months ago

Outdated. Closing.