Closed EmmanuelP closed 4 years ago
I think that's a perfectly sane thing to do, thanks! One little niggle then LGTM.
@hughsie which niggle ?
Ohh, maybe Git Hub didn't save my review comment. Basically, for (i = 0; i < iface->bNumEndpoints; i++)
-> for (guint i = 0; i < iface->bNumEndpoints; i++)
pls.
Fixed. It is not a common pattern in ligusb code base though.
Can you squash the commits down into one commit please, and force push to update this PR. Then LGTM.
Done.
Thanks.
Hi,
Please let me know if you are willing to accept a patch like this that adds a wrapper around the libusb endpoint structure. Not all accessors are implemented yet, and may be it is a bit over enginereed. It could be implemented without adding a new object, just by adding the necessary struct copy and accessors in GUsbInterface.
Cheers,
Emmanuel.