hughsie / oars

The Open Age Ratings Service
GNU Lesser General Public License v2.1
22 stars 6 forks source link

Add Projects using OARS #11

Closed cassidyjames closed 6 years ago

cassidyjames commented 6 years ago

WIP, but adding here for critique. elementary AppCenter would actually need to be removed since we're not doing anything with OARS yet, but included for now for visualization.

image

To-do:

Fixes #9 if merged

danirabbit commented 6 years ago

Does FlatPak actually mandate OARS data as opposed to FlatHub?

I really like the call to action there to include your project. Good call.

cassidyjames commented 6 years ago

Ah, yeah I think I got those mixed up! Corrected in the latest commit.

hughsie commented 6 years ago

I think this is nice. I do think we need to ship the icons ourselves tho. I don't think the ordering matters too much; although "date of adoption" or "number of users" seems like a good metric.

cassidyjames commented 6 years ago

Yeah I was planning on alphabetical naively, but date of adoption might be more meaningful plus easily measurable. Number of users is going to be hard to measure for many projects.

hughsie commented 6 years ago

I'm not sure it matters that much. Project over ego and all that.

Conan-Kudo commented 6 years ago

I'd suggest centering the Your Project icon and making sure it's always on its own row. That makes it more visually distinct and easier to notice.

cassidyjames commented 6 years ago

@Conan-Kudo I disagree since the number of items is variable. Being the last one is a nice ending call-to-action for those who might be looking for a project they're involved with in the list.

cassidyjames commented 6 years ago

I've addressed all but the last TODO: figure out if there are other projects. Other than that, it's ready to review. Current state:

oars

hughsie commented 6 years ago

Looks good to me, can you rebase and squash down and force push the branch please, then LGTM.

cassidyjames commented 6 years ago

@hughsie rebased and squashed

mmstick commented 6 years ago

@hughsie Just a reminder that GitHub's UI provides a Squash and merge and Rebase and merge button alongside Merge so that you can do it from your end without needing to request that a contributor does it on their end (time-consuming).

Conan-Kudo commented 6 years ago

@cassidyjames @mmstick I don't think that's what he was asking for. I think he was asking for some care in the commit message, to make a meaningful set of changes.

The current squashed commit is awful (and is basically the kind of commit message that GitHub generates...).

mmstick commented 6 years ago

@Conan-Kudo GitHub does let you modify the commit message for the resulting squashed / merged commit, however. Easily done from a maintainer's point of view (if they understand what they are merging).