Closed cassidyjames closed 6 years ago
Does FlatPak actually mandate OARS data as opposed to FlatHub?
I really like the call to action there to include your project. Good call.
Ah, yeah I think I got those mixed up! Corrected in the latest commit.
I think this is nice. I do think we need to ship the icons ourselves tho. I don't think the ordering matters too much; although "date of adoption" or "number of users" seems like a good metric.
Yeah I was planning on alphabetical naively, but date of adoption might be more meaningful plus easily measurable. Number of users is going to be hard to measure for many projects.
I'm not sure it matters that much. Project over ego and all that.
I'd suggest centering the Your Project
icon and making sure it's always on its own row. That makes it more visually distinct and easier to notice.
@Conan-Kudo I disagree since the number of items is variable. Being the last one is a nice ending call-to-action for those who might be looking for a project they're involved with in the list.
I've addressed all but the last TODO: figure out if there are other projects. Other than that, it's ready to review. Current state:
Looks good to me, can you rebase and squash down and force push the branch please, then LGTM.
@hughsie rebased and squashed
@hughsie Just a reminder that GitHub's UI provides a Squash and merge and Rebase and merge button alongside Merge so that you can do it from your end without needing to request that a contributor does it on their end (time-consuming).
@cassidyjames @mmstick I don't think that's what he was asking for. I think he was asking for some care in the commit message, to make a meaningful set of changes.
The current squashed commit is awful (and is basically the kind of commit message that GitHub generates...).
@Conan-Kudo GitHub does let you modify the commit message for the resulting squashed / merged commit, however. Easily done from a maintainer's point of view (if they understand what they are merging).
WIP, but adding here for critique. elementary AppCenter would actually need to be removed since we're not doing anything with OARS yet, but included for now for visualization.
To-do:
Fixes #9 if merged