search

hughsie / oars

The Open Age Ratings Service
GNU Lesser General Public License v2.1
22 stars 6 forks source link

Jekyll Layout #13

Closed cassidyjames closed 5 years ago

cassidyjames commented 6 years ago

Fixes #12.

cassidyjames commented 6 years ago

An artificially large diff since it involved splitting up existing files into smaller ones.

hughsie commented 6 years ago

I'm really wondering if it might be easier to convert this to Flask+bootstrap, which gives us the ability to do cleverer things in the future and means I don't need to learn Yet Another Framework...

cassidyjames commented 6 years ago

What I like about Jekyll is that it's stupid simple (just some handy static generation helpers), and supported natively by GitHub Pages. And you're already technically using it in OARS, just not extensively. 😉 But ultimately it's up to you. I've never heard of Flask.

Calinou commented 5 years ago

What's the status on this? I'd like to contribute some changes but would prefer avoiding conflicts if this merged :slightly_smiling_face:

cassidyjames commented 5 years ago

@Calinou if @hughsie doesn't want to use Jekyll than this should be closed, sorry.

cassidyjames commented 3 years ago

@hughsie would you be open to reconsidering this? Jekyll is extremely straightforward and is less of a "framework" and is more just a simple static site generator that allows easy templating. Pretty much any time I want to contribute a change to the OARS generator I'm scared away by the giant single page HTML with lots of repetition everywhere, and something like Jekyll would be much easier to contribute to. Plus, it generates a static site and thus the end result can be identical to what's there now, just easier to work with.

hughsie commented 3 years ago

Jekyll is extremely straightforward

Maybe; the KISS of now does somewhat appeal...