search

hughsie / python-uswid

A tiny tool for embedding CoSWID tags in EFI binaries
Other
19 stars 6 forks source link

Allow importing SWID data from pkg-config files #28

Closed hughsie closed 2 years ago

CodingVoid commented 2 years ago

looks good to me. Although I am not sure if using the filename as tag-id is such a good idea. Maybe instead use the Name attribute in the pkg-config file as base for the tag-id?

hughsie commented 2 years ago

I don't think the Name: is designed as the library name, e.g. I get:

Name: UDisks bcache module
Name: UDisks btrfs module
Name: UDisks iscsi module
Name: UDisks LSM module
Name: UDisks LVM2 module
Name: UDisks Library
Name: UDisks zram module
Name: Wayland Client
Name: Wayland Cursor
Name: wayland-egl-backend
Name: wayland-egl
Name: Wayland Scanner
Name: Wayland Server
CodingVoid commented 2 years ago

Since I am no entirely sure either, let's leave it by the filename.