hughsk / atom-npm-install

Automatically install and save any missing npm modules being used in the current file
http://atom.io/packages/npm-install
MIT License
80 stars 7 forks source link

"Nothing to install" if package name is quoted by backticks. #22

Open zypA13510 opened 6 years ago

zypA13510 commented 6 years ago

Issue: when the required package is quoted by backtick, e.g. var express = require(`express`); in ES6 template string syntax, atom-npm-install will give a Nothing to install! message, instead of installing the required package. Changing the backticks to single quotes and atom-npm-install will recognize them and install correctly.

Steps to reproduce:

  1. Create a new project folder and run npm init with default settings;
  2. Create a new file in the created folder, and name it to index.js;
  3. Paste the following code into index.js:
    var express = require(`express`);
  4. Save the file and run Npm Install: Save from Atom command palette.

Expected result: express installed and added to package.json Actual result: A new panel opened in Atom that says npm install Nothing to install!

Environment: Atom 1.25.1 x64 npm-install 4.0.4