search

hughsk / atom-npm-install

Automatically install and save any missing npm modules being used in the current file
http://atom.io/packages/npm-install
MIT License
80 stars 7 forks source link

consider using npm package directly instead of spawning a new process #6

Open capaj opened 9 years ago

capaj commented 9 years ago

wouldn't it make a little more sense to use npm.install: https://github.com/npm/npm/blob/master/doc/api/npm-install.md instead of spawning a new process?

abdulhannanali commented 9 years ago

hmmmmm

hughsk commented 9 years ago

npm, as wonderful as it is, has all kinds of things going on in its codebase. Using a separate process insulates your editor from that, and I think it's best to stick that way, unless there's a good reason to switch to using the package directly?

capaj commented 9 years ago

@hughsk error handling should be easier, because you don't have to parse the command line errors. How do you handle errors now?