hughsk / envify

:wrench: Selectively replace Node-style environment variables with plain strings.
902 stars 57 forks source link

(Hopefully) remove esprima-fb dependency #13

Closed zertosh closed 9 years ago

zertosh commented 10 years ago

I've submitted this PR https://github.com/facebook/jstransform/pull/29. If that gets merged then it's possible to simplify the dependencies so that there isn't a case of multiple esprima-fb versions as described in the PR's comment.

I'd be more than happy to submit a PR that basically does this when the time is right:

diff --git a/package.json b/package.json
index fcfc0a6a..a01af729 100644
--- a/package.json
+++ b/package.json
@@ -21,8 +21,7 @@
   "dependencies": {
     "xtend": "~2.1.2",
     "through": "~2.3.4",
-    "esprima-fb": "^4001.3001.0-dev-harmony-fb",
-    "jstransform": "^6.1.0"
+    "jstransform": "WHATEVER_VERSION_IS_NEXT"
   },
   "keywords": [
     "environment",
diff --git a/visitors.js b/visitors.js
index 48cb1548..e93848f6 100644
--- a/visitors.js
+++ b/visitors.js
@@ -1,5 +1,5 @@
-var Syntax = require('esprima-fb').Syntax
 var utils = require('jstransform/src/utils')
+var Syntax = utils.Syntax

 function create(envs) {
zertosh commented 10 years ago

@hughsk, the change has been merged into jstransform. This PR https://github.com/hughsk/envify/pull/14 removes the esprima-fb dependency.

zertosh commented 9 years ago

Resolved by https://github.com/hughsk/envify/pull/14