Fix invalid replacement when assignment

hughsk / envify

:wrench: Selectively replace Node-style environment variables with plain strings.

902 stars 57 forks source link

Fix invalid replacement when assignment #23

Closed zertosh closed 9 years ago

zertosh commented 9 years ago

The tests passed before because they were testing computed MemberExpressions, which aren't supported. Brought up in https://github.com/hughsk/envify/pull/21.

@yoshuawuyts Can you give this a quick look before I merge + publish?

zertosh commented 9 years ago

@hughsk Not sure what your policy is on collaborators merging their own PRs. A little guidance please?

hughsk commented 9 years ago

@zertosh ah sorry, missed this one – thanks! Looks good to me. In the future I'd say submit a PR, and if you don't hear from me after a day then merge away :)

zertosh commented 9 years ago

@hughsk It's ok, I just realized I didn't mention in the original comment - sorry. Waiting a day sounds reasonable, besides, I feel like envify is "done" as in a "it's finished product". I only really see jstransform updates and hopefully this https://github.com/hughsk/envify/pull/21 in it's near future.