hughsk / s3-sync

A streaming interface for uploading multiple files to S3.
Other
79 stars 27 forks source link

Files are not recognized as changed if they are modified with something other than s3-sync #13

Open dtmcmath opened 9 years ago

dtmcmath commented 9 years ago

If I mix tools like s3cmd and s3-sync, I can end up PUTting a file without including the "x-amz-meta-syncfilehash" header. Then subsequent calls to s3-sync won't recognize the file as changed and just glides silently past it.

I'm sorry for being a bad citizen and not providing a simple test case. I'm actually using this through grunt-s3-sync, so it's a little awkward. I do have a proposed fix, though, that works for me. It's over at my fork so I guess I'll make a pull request.

dtmcmath commented 9 years ago

Pull request #18 is a much simpler way of saying the same thing I was trying to say.