search

hughsk / s3-sync

A streaming interface for uploading multiple files to S3.
Other
79 stars 27 forks source link

Change knox to aws-sdk in order to support v4 aws signatures #30

Closed andreialecu closed 3 years ago

andreialecu commented 8 years ago

See https://github.com/hughsk/s3-sync/issues/29

There are some minor potential breaking changes since now aws-sdk style parameters are expected instead of knox style parameters.

So for example headers will now expect CacheControl instead of the HTTP Cache-Control knox works with.

antony commented 8 years ago

Any chance of this making it into the main codebase? The library is simply broken in frankfurt without it.

jrbenito commented 8 years ago

@hughsk,

This is really an important feature. Could you please merge this and bump version on npm?

Thanks

andreialecu commented 8 years ago

You can use my fork at https://github.com/andreialecu/s3-sync-aws which has this.

It's also on npm as s3-sync-aws