search

hughsk / smokestack

Pipe your JavaScript into a browser, logging console output in Node
Other
245 stars 26 forks source link

Sometimes not exiting #44

Closed mattdesl closed 9 years ago

mattdesl commented 9 years ago

With recent versions of smokestack and/or tap-closer I've noticed the window is closing, but the process is not exiting so it hangs. I am running things locally at the moment.

Will keep looking into it...

joeybaker commented 9 years ago

Happens every time for me with anything after smokestack 3.2

joeybaker commented 9 years ago

Nope, I'm wrong. The only pattern I really see is that it exits successfully once after a new smokestack install, then hangs on subsequent runs.

joeybaker commented 9 years ago

@mattdesl did you ever get anywhere on this?

mattdesl commented 9 years ago

nope, sadly

Sent from my iPhone

On Jul 9, 2015, at 3:46 PM, Joey Baker notifications@github.com wrote:

@mattdesl did you ever get anywhere on this?

— Reply to this email directly or view it on GitHub.

joeybaker commented 9 years ago

so… small progress: the problem doesn't happen if I use firefox. So, it's likely something in chrome-launcher

joeybaker commented 9 years ago

Seems to be related to chrome not exiting cleanly: https://code.google.com/p/chromium/issues/detail?id=338000

tmcw commented 9 years ago

Also running into this quite often in our testing stack

joeybaker commented 9 years ago

@tmcw FWIW, https://github.com/hughsk/chrome-launch/issues/2 fixed the issue for me.

hughsk commented 9 years ago

Apologies for the delay here all! This should be fixed in smokestack@3.3.1 thanks to @joeybaker's patch, let me know if there are any further issues :)

cdaringe commented 7 years ago

hello. it hangs for me in both browsers :/ chrome & ff