The 'ignore' option is broken for hidden files & files inside hidden directories

hughsk / uglifyify

A browserify transform which minifies your code using UglifyJS2

Other

375 stars 61 forks source link

The 'ignore' option is broken for hidden files & files inside hidden directories #51

Open Lucas-C opened 8 years ago

Lucas-C commented 8 years ago

Due to this longstanding minimatch bug, the ignore option will never filter out files containing a directory starting with a dot anywhere in their path, nor files starting with a dot.

E.g. /home/bob/.jenkins/jobs/HellowWorld/workspace/snafu.js

Lucas-C commented 8 years ago

Actually minimatch provides an option for this : could uglifyify use {dot: true} by default ?

Lucas-C commented 8 years ago

Any update on this @hughsk ?

kevincolten commented 7 years ago

@Lucas-C @hughsk take a look at my PR

Lucas-C commented 7 years ago

Looks great ! Thanks. Could you merge this PR @hughsk please ?

Lucas-C commented 7 years ago

@hughsk : any update on this ?