Feature request about section Experiences (show logo company)

[niltied]

Hi @hossainemruz

After all the work done on Toha v4, I think, it's time to make evolution on the frontend of Toha.

So, first, i closed my initial issue #827. Because, i'm not satisfy about the content of this issue, and I'm not an developer. I feel not be able to dev this feature. So, i make this new issue with more explications here for any people.

Definition of Ready

I would like to have the possibility to add the logos of the companies where I worked in the Experience section. I've put an example below that describes the imagined presentation, and I've also added some sample code that might meet this need.

I post the code showed in the image to make it clearer.

experiences:
  - company:
      name: Example.co
      logo: image/experience/logo.example.co.jpg
      url: https://www.example.co
      location: Washington DC
  - positions:
      designation: Software engineer
      start: Mar 2016
      end: May 2017

The idea is :

• We add the path of the logo image for each experience section added in the experience.yaml file.
• We add the image in asset/sections/experiences/ directory.

Definition of Done

• [ ] Feature delivered
• [ ] Experience Guide updated

What do you think ?

[BernatBC]

I think we should do the same to the education section, showing logos of colleges and schools. By the way @niltied, you can close an issue that you created with a button next to the comment button

[niltied]

I'm agree @BernatBC. We should do the same to the education section. But it must be tested to have an preview.

[BernatBC]

I could accomplish this:

I can do some changes, cause I'm not totally convinced with the design

[hossainemruz]

Maybe, we can follow similar style as LinkedIn.

[BernatBC]

Sure, but I'll need some help with it

[hossainemruz]

Okay. I will give a try. No promise on the timeline.

[niltied]

I don't think a presentation like linkedin would be suitable. The position of the logo requires square images. Not all companies or schools necessarily have a square logo, very often it is rectangular. The solution I proposed, I have seen it elsewhere and it works. Square and rectangular case.

[niltied]

An example :

[hossainemruz]

I don't think a presentation like linkedin would be suitable. The position of the logo requires square images. Not all companies or schools necessarily have a square logo, very often it is rectangular.

That make sense. Your example one looks good @niltied. We can go with it.

[BernatBC]

If you want, I can do a PR with this

[hossainemruz]

Sure. Go ahead @BernatBC .

[niltied]

+1. @hossainemruz is OK too, go ahead @BernatBC. It's OK for me. You confirm that it's OK for experiences section too ? Not only education ? right ?

[BernatBC]

@niltied Yes, you can check the Pull Request to see how it looks for the experiences section.

[niltied]

I saw @BernatBC

I can't wait to test it on my site !