search

hugo-toha / toha

A Hugo theme for personal portfolio
https://hugo-toha.github.io
MIT License
979 stars 567 forks source link

Migrate to Bootstrap 5 #918

Closed BernatBC closed 3 months ago

BernatBC commented 3 months ago

Issue

Fixes #906

Description

Migrate Bootstrap 4 to 5.

I've done some testing, but there might be something odd (specially if the config is different than hugo-toha.github.io). If anyone finds some bugs, please tell me.

netlify[bot] commented 3 months ago

Deploy Preview for toha-ci ready!

Name Link
Latest commit e6520aed315a0ac27c565f32f5efcc7a9891b71c
Latest deploy log https://app.netlify.com/sites/toha-ci/deploys/66241dd32d2a0900087e893f
Deploy Preview https://deploy-preview-918--toha-ci.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

hossainemruz commented 3 months ago

Thank you @BernatBC! I will take a look soon. From checking the deploy preview, look like the drop downs are not working.

BernatBC commented 3 months ago

Looks like I forgot to update Bootstrap to 5 in the example site. Now it should work.

BernatBC commented 3 months ago

For some reason it's not working in the preview, but it's fine locally.

hossainemruz commented 3 months ago

@BernatBC I have pushed few changes. They fixes the following issues:

  1. Scroll spy was not working
  2. Dropdown was not working
  3. Card had accent color title instead of text color
  4. Navbar brand title had text decoration
  5. Sidebar and navbar switcher had border around them.
  6. Scroll-to-top button had outline around it

I am pretty sure more issues will pop up. However, I think it is good enough for now. We will fix them when user reports them.

hossainemruz commented 3 months ago

For some reason it's not working in the preview, but it's fine locally.

Apparently, you forgot to update package.hugo.json which is used to generate package.json for the sites that uses this theme.