search

hugoattal / DarkerNodes

Modern theme for the Unreal editor
51 stars 2 forks source link

Request: Option to hide Marketplace Icon #163

Closed TheBanishingOfMosquito closed 2 years ago

TheBanishingOfMosquito commented 2 years ago

DefaultMarketplaceIcon NoMarketplaceIcon

Can you hide this button pls. Just using the color of the toolbar as a plane top to hide the name and symbol would be fine. Even if its clickable. Actually this button doesnt work anyway.

I think we dont need this button. Its taking visuall space away. And the symbol is too strong. Feels like we are in a shopping maul. If I am in supermarket I always try to get out asap.

IMHO the levelviewport should not be to place to be constantly reminded that we can go to the marketplace and buy stuff. Its kind of an advertisment. Would be great if we can block it. (see image above)

hugoattal commented 2 years ago

I totally understand your feeling about it, and I 100% agree that this button shouldn't be here in the first place.

But I can't remove it as it is hard coded into the engine. I can only "hide" it by making the icon transparent (which will still display the "marketplace" text and be clickable). So I don't think it would be a good solution...

I'll look if I can make something to hide it completely, but I'm not sure if it's possible without recompiling the whole engine.

TheBanishingOfMosquito commented 2 years ago

Transparent icon sounds good. In my case, even if I click nothing happens. It seems to be the case for many users.

For the"marketplace" text changeing the font color to the same picked color. Is this doable to let it have another color-id than the other fonts next to it?

This would work right? Yes would be a cracky solution, visually it should work though Doable

hugoattal commented 2 years ago

In my case, even if I click nothing happens. It seems to be the case for many users.

I'm afraid this has nothing to do with Darker Nodes, it's just on the "vanilla" engine...

changing the font color to the same picked color

Well, this is not possible... To simplify a bit, there's many "model" of fonts generated by the engine, and I can only modify the color of some of them. To be fair, I can modify this model, but all the texts based on this model will be affected, meaning all the text of the toolbar (and possibly more) will be invisible. And of course, I can't change the font model used by the text "Marketplace" 😕...

TheBanishingOfMosquito commented 2 years ago

Too bad that Epic doesnt let us change it by default. There is one more thing> image image

If the toolbar is in small mode. There is no text! So in other words. If you include the alpha option that you suggested . We can hide it as loong as we use the ''Use Small Tool Bar Icons'' behaviour. What do you think. I would say most of us use small icons for screen space reasons in the first place.

If there is a checkbox for this turned off by default. As Experimental. Fot the community part who wants to try this out, we can turn on. This would be great.

hugoattal commented 2 years ago

Well why not then. I'll add a checkbox "Hide Marketplace icon" for the next version.

TheBanishingOfMosquito commented 2 years ago

Awsome, will be grateful!✨

hugoattal commented 2 years ago

Rejected for version 3 (Sorry, I'm focusing on UE5 compatibility and new features... 😕)

One solution for you could be to delete the icon from the plugin folder located in D:\Program Files\Epic Games\UE_4.27\Engine\Plugins\Marketplace\DarkerNodes\Resources\Theme\Menu\Line