hugoattal / DarkerNodes

Modern theme for the Unreal editor
51 stars 2 forks source link

DarkerNodes compliling errors on Android ASTC #170

Open NoNeutrality opened 2 years ago

NoNeutrality commented 2 years ago

Love your plugins man! Hoping you might of run into this before.

UATHelper: Packaging (Android (ASTC)): LogShaderCompilers: Display: /DarkerNodes/lib/Shapes.usf(12): error: syntax error, unexpected STATIC

Exo_FullLog.log Exo_DarkerNodesErrors.log

The FAQ mentions shader compiling errors, but setting r.ShaderDevelopmentMode to 0 had no impact. "LogSlate: Window 'Project Settings' being destroyed LogSlate: Window 'Output Log' being destroyed LogSlate: Window 'Output Log' being destroyed Cmd: r.ShaderDevelopmentMode 0 r.ShaderDevelopmentMode = "0" LogUObjectHash: Compacting FUObjectHashTables data took 0.78ms LogMainFrame: Project requires temp target (ControlRig plugin is enabled)"

UE 4.27 Blueprints No other plugins

Able to compile to Windows but not Android

hugoattal commented 2 years ago

I should it was fixed in this: https://github.com/hugoattal/DarkerNodes/issues/131

Did you update DN to the last version?

NoNeutrality commented 2 years ago

Hey thank you for the response.

That prior issue does look similar.

My installed Darker Nodes version is 2.6. Electric Nodes is 3.5. UE 4.27.2

I can see in that prior issue where you mention you implemented this fix. "While the source of the particular shader compiler error is pretty mysterious, changing the DarkerNodes module to use EditorNoCommandlet as its Type (instead of Editor) in the .uplugin will prevent it from being loaded by the cooker, which means that it'll no longer reference those materials -- which is what's causing it to be included in the cook."

Though I wonder if since 4.25 to 4.27 something might of changed.

-

Just did another pair of package attempts.

With Darkner nodes installed, I get the same error as prior. Disabling and restarting the editor, I'm able to package to Android ASTC successfully.

Re-enabled, restarted, "UATHelper: Packaging (Android (ASTC)): LogShaderCompilers: Display: /DarkerNodes/lib/Shapes.usf(12): error: syntax error, unexpected STATIC"

-

Correction: After resolving another error, I do get BUILD SUCCESSFUL even with Darker nodes enabled, but that error message is mentioned throughout the log. I don't know how important that is. I'll be testing on the target hardware this weekend.