hugoattal / ElectronicNodes

Wiring style for blueprint and material editors in the Unreal Engine
99 stars 10 forks source link

Startup pop-up crashes the engine in Commandlet mode #43

Closed avudnez closed 3 years ago

avudnez commented 3 years ago

Describe the bug Title says it all.

To Reproduce

  1. Enable the plugin
  2. Remove the .ini file used to determine first launch (simulate a first launch)
  3. Launch a commandlet

Expected behavior The plugin does not crash the engine.

Environment (please complete the following information):

hugoattal commented 3 years ago

I'm really sorry for this, I really tried to make this popup frictionless...

I tried to set up a commandlet, but I'm not familiar with such a feature.

Here's what I did:

Here are the versions I tested for the .bat file:

"D:\Program Files\Epic Games\UE_4.26\Engine\Binaries\Win64\UE4Editor-Cmd.exe" -project="D:\Library\Documents\Unreal Projects\PluginTestFPS 4.26\PluginTestFPS.uproject" -run=HelloWorld
"D:\Program Files\Epic Games\UE_4.26\Engine\Binaries\Win64\UE4Editor-Cmd.exe" "D:\Library\Documents\Unreal Projects\PluginTestFPS 4.26\PluginTestFPS.uproject" -run=HelloWorld
"D:\Program Files\Epic Games\UE_4.26\Engine\Binaries\Win64\UE4Editor-Cmd.exe" "PluginTestFPS 4.26" -run=HelloWorld
"D:\Program Files\Epic Games\UE_4.26\Engine\Binaries\Win64\UE4Editor-Cmd.exe" "PluginTestFPS" -run=HelloWorld

But it always ended with this error: image

Do you have any idea what command line I should use to use the commandlet?

CanisHelix commented 3 years ago

I cannot package on a headless Linux server due to the popup, it causes a malloc error with slate. I had the same thing with another plugin (albeit they had it in a separate 'module' so it was easier to disable via the .uproject file). I have since written scripts to remove ElectronicNodes from projects upon submitting to CI/CD servers.

avudnez commented 3 years ago

For an example of commandlet that we tried and failed, you can run UE4Editor.exe <ProjectName> -run=loadpackage [arguments].

hugoattal commented 3 years ago

@CanisHelix Sorry for that... You could also have disabled the popup in Edit/Editor Preferences/Electronic Nodes image

I'm going to check if the engine is in headless mode before displaying any popup. Again, I'm really sorry it made that much trouble...

CanisHelix commented 3 years ago

@hugoattal That might work, I'll see if I can get that flipped in the .ini before the CI/CD runs.

hugoattal commented 3 years ago

Ok, so I added a check that might fix the issue image

Unfortunatly, I wasn't able to test it (or to make commandlet works), so... finger crossed 🤞 ! It will be able in 3.4 version.