search

hugoattal / ElectronicNodes

Wiring style for blueprint and material editors in the Unreal Engine
99 stars 10 forks source link

Global Setting doesn't ask to check out Settings.ini when source control is enabled #68

Closed nchapmantimberline closed 1 year ago

nchapmantimberline commented 1 year ago

If you are using global settings and have source control enabled, you need to check out the settings file before saving/deleting it. The plugin currently does not do this, so you have to check it out manually to make it work. Other ini's in Unreal prompt the user to check out the ini when making changes.

hugoattal commented 1 year ago

Duplicate of #67

hugoattal commented 1 year ago

Hum, globals are configuration for every unreal projects (and not specific to the current unreal project), so I'm not sure you want to commit it.

But I can hide the warning so that if globals are activated, and there's no global configuration, it actually create a new one. Wdyt?

nchapmantimberline commented 1 year ago

Hmm, that's a good point. Essentially, what we want to be able to do is easily set project-level settings for ElectronicNodes, because once you start using it, everyone kinda has to use it because otherwise if a user using the default unreal layout opens one that was laid out assuming electronicnodes, it will look quite messy. So I don't know if that's something we would achieve through the standard editor settings or not!

From: Hugo ATTAL @.> Sent: Monday, May 22, 2023 6:29 AM To: hugoattal/ElectronicNodes @.> Cc: Nathaniel Chapman @.>; Author @.> Subject: Re: [hugoattal/ElectronicNodes] Global Setting doesn't ask to check out Settings.ini when source control is enabled (Issue #68)

Hum, globals are configuration for every unreal projects (and not specific to the current unreal project), so I'm not sure you want to commit it.

But I can hide the warning so that if globals are activated, and there's no global configuration, it actually create a new one. Wdyt?

— Reply to this email directly, view it on GitHubhttps://github.com/hugoattal/ElectronicNodes/issues/68#issuecomment-1557225445, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARLFFYOPZBSC3RCHTG67SWLXHNS25ANCNFSM6AAAAAAYG3LWJY. You are receiving this because you authored the thread.Message ID: @.***>

Caution: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender (check both name and email address) and know the content is safe.

hugoattal commented 1 year ago

Well, if you disable global settings, the settings will be on per project basis. It will be saved in the same place others plugins are saved: [game dir]/Saved/Config/WindowsEditor/EditorPerProjectUserSettings.ini

Does it solve your issue?