search

hugobessa / django-shared-schema-tenants

A lib to help in the creation of shared schema multi tenants applications without suffering
MIT License
20 stars 9 forks source link

Dynamic settings #22

Closed hugobessa closed 6 years ago

hugobessa commented 6 years ago

The old settings flow wasn't getting the correct values for settings that were updated in runtime.

The main problem this leads to is with testing, because we can't override settings with django override_settings decorator.

This created a new flow, where settings are now picked from a get_setting helper passing the settings name as a string. This grants that we always have the correct value for settings.

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@49a6dd8). Click here to learn what that means. The diff coverage is 80.76%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev      #22   +/-   ##
======================================
  Coverage       ?   87.35%           
======================================
  Files          ?       21           
  Lines          ?      617           
  Branches       ?       66           
======================================
  Hits           ?      539           
  Misses         ?       65           
  Partials       ?       13
Impacted Files Coverage Δ
...red_schema_tenants/helpers/tenant_relationships.py 64.28% <ø> (ø)
shared_schema_tenants/settings.py 100% <100%> (ø)
shared_schema_tenants/mixins.py 100% <100%> (ø)
shared_schema_tenants/helpers/tenant_settings.py 100% <100%> (ø)
shared_schema_tenants/middleware.py 88.33% <100%> (ø)
shared_schema_tenants/models.py 82.69% <100%> (ø)
shared_schema_tenants/helpers/tenant_extra_data.py 100% <100%> (ø)
shared_schema_tenants/helpers/tenants.py 93.33% <100%> (ø)
shared_schema_tenants/views.py 50.81% <54.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 49a6dd8...cf26c95. Read the comment docs.