search

hugocruzz / PyLake

This package present methods used to compute meaningful physical properties in aquatic physics.
8 stars 6 forks source link

Replace seawater with GSW #3

Closed bhlevca closed 3 months ago

bhlevca commented 3 months ago

Sewawater was deprecated please replace seawater with GSW. I replaced it in all my code,

When using pylake I getting this warning: pylake.py:3: UserWarning: The seawater library is deprecated! Please use gsw instead.

f-baerenbold commented 3 months ago

Hello

I was trying gsw instead and get an error: AttributeError: module 'gsw' has no attribute 'cp'

Also, I am not getting the warning for seawater (using python 3.9). But thanks for posting, we will look into this at a later stage.

bhlevca commented 3 months ago

I am using Python version 3.12. However, I think that seawater itself is issuing the deprecating warning as the Python distribution does not know about its libraries.

The repository at https://github.com/eawag-surface-waters-research/PyLake does not seem to accept Issues. Which one should I follow?

f-baerenbold commented 3 months ago

I enabled the issues. Please write it there and I will look into it at some point.

bhlevca commented 3 months ago

Done