search

hugofirth / laravel-mailchimp

A composer package for the MailChimp API PHP class (as provided by MailChimp) which supports the Laravel 4 framework.
96 stars 27 forks source link

mailchimp-api-php requires updating for CURLOPT_FOLLOWLOCATION bug fix #21

Open maximerassi opened 10 years ago

maximerassi commented 10 years ago

https://bitbucket.org/mailchimp/mailchimp-api-php/pull-request/8/bug-in-set-curlopt_followlocation-opt/activity

markovic131 commented 10 years ago

It is still not tagged at Bitbucket. The fix is currently on "master" branch, but hugofirth/laravel-mailchimp uses "2.0.5".

hugofirth commented 10 years ago

Correct. I prefer to specify 2.0.* versions so that I try and ensure breaking changes like this don't happen -.-

markovic131 commented 10 years ago

@hugofirth Yeah... So I guess we gonna have to wait for them to tag another.. :)

hugofirth commented 10 years ago

I'm in unfamiliar territory here. I'm keen not to break the rules of semantic versioning. Is it worth tagging a bug fix release in which the dependency is shifted to mailchimp's master branch, and then release another bug fix release as soon as they tag a new release reverting the dependency to 2.0.* ?

markovic131 commented 10 years ago

Hmm... Idk too. It all boils down to "Do you want your users to have buggy package?". Its doesn't matter if the bug comes from Mailchimp. I reckon the end goal is for us (the users of your package) to have a working code with decent stability.

Its your call.

warkior commented 10 years ago

Is there a way to fix this temporarily somehow? Maybe you could publish a special branch or revision that references the master branch in the other package?

momar12 commented 10 years ago

The bitbucket link quoted above has a solution posted on the thread.

Initial composer : "require": { .... "hugofirth/mailchimp": "2.0." // This package require 2.0.5 }, Modified composer : "require": { .... "mailchimp/mailchimp": "dev-master as 2.0.5", // Alias "hugofirth/mailchimp": "2.0." },

Post by Pierre Regal. Just change 2.0.5 to 2.0.6. Solves it for me

markovic131 commented 9 years ago

The bug has been fixed on 2.0.6. So hugofirth/laravel-mailchimp is not affected anymore. You can close the issue.