Some corrections - Githubissues

hugokernel / Hyla_Tpl

Php tpl engine based on tpl engine from phplib

http://tpl.hyla-project.org/

GNU General Public License v2.0

2 stars 1 forks source link

Some corrections #1

Closed erichard closed 13 years ago

erichard commented 13 years ago

Fix a problem with the default value '0'
Migrate private attr and method to protected to allow extending Hyla_tpl
Update tests

hugokernel commented 13 years ago

Hi, Thx

Ok fot the 0 default value bug. i'not sure make all private variable in protected is a good idea, ok for some method but all...

Regards

erichard commented 13 years ago

Yeah, you're surely right.

Put all attributes and methods in protected visibily is a dumb solution. I'll check methods we use and attributes we exactly need for our herited classe and make a separate PR for that.

Do you want another PR for the 0 defalut value bug ?

hugokernel commented 13 years ago

I'll check methods we use and attributes we exactly need for our herited classe and make a separate PR for that.

Ok, great !

Do you want another PR for the 0 defalut value bug ?

Yes, please

Thank you !