search

hugolabe / Wike

Wikipedia Reader for the GNOME Desktop
https://hugolabe.github.io/Wike/
GNU General Public License v3.0
231 stars 32 forks source link

Two small fixes #113

Closed ghost closed 1 year ago

ghost commented 1 year ago
hugolabe commented 1 year ago

Thanks @sabriunal !

  • UI: Add a tooltip to the pin/unpin action

I decided not to put the Pin Button tooltip because it seems to me that its function is very obvious and I am in favor of using as few tooltips as possible. What do you think?

  • UI: Use ellipses instead of three dots

Ok!

ghost commented 1 year ago

I use Breeze theme from KDE. Two buttons seem missing. Still I can know the first one is sidebar from tooltip. The second one have no icon and no tooltip. There is no way to know what this button do. Also, other tabs (history, bookmarks, languages, contents) have tooltips except this button.

Ekran Görüntüsü - 2023-04-01 12-47-46

hugolabe commented 1 year ago

Ok, we put it.

It's strange, both icons are part of GNOME's pre-installed system icons.

One last thing: Wouldn't Pin Sidebar be clearer for the tooltip? It doesn't seem to me necessary to specify the opposite action.

ghost commented 1 year ago

OK. I chaged the string.

camelCaseNick commented 1 year ago
  • UI: Use ellipses instead of three dots

What about applying this change there as well: https://github.com/hugolabe/Wike/blob/a2e9c333608ee778050b1e4af5e55b7f30415e60/data/com.github.hugolabe.Wike.metainfo.xml.in#L20

hugolabe commented 1 year ago

OK. I chaged the string.

Thanks!

hugolabe commented 1 year ago
  • UI: Use ellipses instead of three dots

What about applying this change there as well:

https://github.com/hugolabe/Wike/blob/a2e9c333608ee778050b1e4af5e55b7f30415e60/data/com.github.hugolabe.Wike.metainfo.xml.in#L20

Yes. Since I have to update the POT template, I take the opportunity to change it.