hugolabe / Wike

Wikipedia Reader for the GNOME Desktop
https://hugolabe.github.io/Wike/
GNU General Public License v3.0
231 stars 32 forks source link

[v2] decouple flap state from pin-sidebar action to restore pinned state after re-expanding window #128

Closed camelCaseNick closed 1 year ago

camelCaseNick commented 1 year ago

This is a follow-up to #118.

The pin-sidebar action's state, being user intend for a pinned sidebar, can and will be overruled for lack of space. Currently, this overruling is made permanent, so shrinking the window and re-expanding it will result in the previously pinned sidebar to not be pinned anymore.

With decoupling the flap state from the pin-sidebar action, this overruling is made temporary with the user's previous setting restored.

As a follow-up, the button to pin the sidebar is when disabled of no use, and could even confuse due to the button's state not reflecting the sidebar's state. To solve this confusion, the button can be hidden, when the sidebar is forced into the collapsed mode on smaller screens or window widths.

changes since v1:

wike-pin-sidebar.webm