search

hugolabe / Wike

Wikipedia Reader for the GNOME Desktop
https://hugolabe.github.io/Wike/
GNU General Public License v3.0
231 stars 32 forks source link

Missing icons on KDE #133

Closed spoorun closed 7 months ago

spoorun commented 1 year ago

When running on KDE (with Wayland) the icons are missing in at least 3 places. See attached image. Missing icons highlighted.

wike-missing-icons-kde2

archisman-panigrahi commented 1 year ago
  1. Which version of Wike are you using?
  2. How did you install Wike?
  3. Which operating system?
xfgusta commented 1 year ago

I can reproduce it on Fedora Linux 38 and Wike 2.0.1 (built from source). It looks like we're using the Breeze icon, which doesn't include some icons like sidebar-show-right-symbolic. Changing Breeze to Adwaita works, but it's not ideal.

image

A possible fix would be to include these icons in the same way as done here: https://github.com/hugolabe/Wike/tree/master/data/icons/scalable/actions.

hugolabe commented 1 year ago

Tested on Manjaro KDE (live image) works fine for me.

Screenshot_20230426_152436

It looks like we're using the Breeze icon, which doesn't include some icons like sidebar-show-right-symbolic.

However, it seems strange that such common icons as the printer one are not displayed. And the rest of the icons, which are shown correctly on the screenshot, correspond to the Adwaita set. Shouldn't Breezie's be showing?

A possible fix would be to include these icons in the same way as done here: https://github.com/hugolabe/Wike/tree/master/data/icons/scalable/actions.

Yes, this would fix any icon issues. But in this case I think it would be best to install all the application icons as gresources, to avoid mixing different themes in case you are using a different set than Adwaita.

archisman-panigrahi commented 1 year ago

image

image

In Kubuntu 22.04 (Wike installed via flatpak), I can see the printer icon and new tab icon, but not some other icons (breeze icon theme). All icons are correctly displayed in Papirus and Adwaita icon themes.

xfgusta commented 1 year ago

In Kubuntu 22.04 (Wike installed via flatpak), I can see the printer icon and new tab icon, but not some other icons (breeze icon theme). All icons are correctly displayed in Papirus and Adwaita icon themes.

Same here.

spoorun commented 1 year ago

  1. Which version of Wike are you using? 2.0.1

    1. How did you install Wike? via Flatpak

    2. Which operating system? Manjaro Linux with KDE 5.27.4 running with Wayland

Apologies for not posting originally (I'd figured this was a problem with KDE compatibility).

spoorun commented 1 year ago

In Kubuntu 22.04 (Wike installed via flatpak), I can see the printer icon and new tab icon, but not some other icons (breeze icon theme). All icons are correctly displayed in Papirus and Adwaita icon themes.

In Manjaro KDE (Breeze icon theme) I'm missing the sidebar icon, new tab icon, and printer icon

hugolabe commented 1 year ago

39b8ec2b64a30cecc4a37fa5562e40db1b6a49d7

I've included most of the action icons as gresources (except the most common ones). This should fix the issue of missing icons when using themes that don't include some of them.