hugolabe / Wike

Wikipedia Reader for the GNOME Desktop
https://hugolabe.github.io/Wike/
GNU General Public License v3.0
228 stars 32 forks source link

appdata: Improve appdata for AppStream 1.0 #174

Closed ghost closed 6 months ago

ghost commented 6 months ago

Appdata: Fix my mistake

"Icons and categories

If there’s a type="desktop-id" launchable, they get pulled from it. Most of the icon not found errors with the flathub builder can be traced down to the launchable value not matching the desktop file name.

Don’t set them in the AppData unless you want to override them (even though then it might be a better idea to patch the desktop file itself)."

More information: https://docs.flathub.org/docs/for-app-authors/appdata-guidelines/#icons-and-categories

camelCaseNick commented 6 months ago

AppStream – Upstream Metadata says:

[…] The element should have a id property, containing a unique ID to identify the respective developer. […]

So, it seems the id should not identify the origin of the source, or where the <name> is used, but rather be a website controlled by the developer, such as hugolabe.github.io.

ghost commented 6 months ago

It's up to the developer; my viewpoint differs from yours.

The element is designed to represent the developers or project responsible for development of the project described in the metadata.

The element should have a id property, containing a unique ID to identify the respective developer. It is recommended to use a web URL, like gnome.org as ID to achieve a higher chance of uniqueness.

Every developer element must have a name tag as child, which contains a translatable name for the respective developer. Values might be for example "The GNOME Foundation" or "The KDE Community". Hyperlinks or emails must not be used in the name; if you want to link to the developer's homepage, use the -tag instead. The name tag is translatable.

  <developer id="example.org">
    <name>FooBar Team</name>
  </developer>
hugolabe commented 6 months ago

Thanks @sabriunal !

Wouldn't it be better to remove the developer_name tag, since it is obsolete?

ghost commented 6 months ago

Flathub and GNOME Software do not yet support the new tags.