hugolabe / Wike

Wikipedia Reader for the GNOME Desktop
https://hugolabe.github.io/Wike/
GNU General Public License v3.0
228 stars 32 forks source link

add ability to display window controls in every toolbar view #177

Closed camelCaseNick closed 5 months ago

camelCaseNick commented 5 months ago

Using Adw.HeaderBar as the top child of an Adw.ToolbarView ensures that window controls are always displayed correctly. This is an issue for the small window sizes (<= 450px width), where the sidebar does not display them. This is, however, the normal behaviour for those kinds of sidebars covering the whole app's primary window.

Additionally, the left most pane visible in medium and large window mode (<= 750px and 751px+) would need manually added Gtk.WindowControls for side: start to supported close buttons on the left for completeness purposes.

(You cannot close Wike in medium and large window mode if the button layout is "close:", i.e. the close button is on the left.)

hugolabe commented 5 months ago

This causes some glitches with the app's design, especially in the first sidebar. And if you have more than one window control activated on the left side, it completely breaks the design.

wike-header2 wike-header1

I think the best option is to always place the controls in the content area of the window, since there is no space in the sidebars.

(You cannot close Wike in medium and large window mode if the button layout is "close:", i.e. the close button is on the left.)

True. I can easily solve this by replacing the AdwHeaderBar with a GtkHeaderBar.

wike-header3