search

hugolabe / Wike

Wikipedia Reader for the GNOME Desktop
https://hugolabe.github.io/Wike/
GNU General Public License v3.0
252 stars 33 forks source link

going back in page history does not reload theme #82

Closed janxkoci closed 2 years ago

janxkoci commented 2 years ago

Very nice app, very useful, thank you for it.

I noticed this tiny issue, where I got a page with wrong theme after changing it and navigating back in history.

Steps to reproduce

  1. open some article
  2. click any link to navigate to a new article
  3. after loading new article, change theme (e.g. from dark to sepia)
  4. return back to previous article
    • here you see the old theme
  5. go to different article - theme is back to the new one

Screenshot

Here is a screenshot of a popover menu with a new theme selected, but article having different (old) theme. Notice the history arrows, indicating how we got here.

Snímek z 2022-05-16 19-10-38

Also note that the article in the other tab reloaded the theme properly, so no such issue there.

hugolabe commented 2 years ago

Thank you!

It's true. This is because when using the navigation buttons, webkit loads the pages from the cache.

Fixed in commit 715908a76a4d692bdd3c2356e97e2327bc0d6b56

janxkoci commented 2 years ago

Yeah I thought so. Thanks for the fix :)

janxkoci commented 2 years ago

I can confirm the issue is fixed now.