search

hugoledoux / startinpy

A Python library for modelling and processing 2.5D terrains using a (2D) Delaunay triangulation.
https://startinpy.rtfd.io/
MIT License
25 stars 6 forks source link

Cargo.toml: Specify minimum instead of exact versions #8

Closed EwoutH closed 2 years ago

EwoutH commented 2 years ago

Specify minimum versions instead of exact versions in Cargo.toml, to allow dependency upgrades.

Also require at least pyo3 version 0.13, to allow for cross compilation.

hugoledoux commented 2 years ago

this fails because pyo3::exceptions does not have IOError anymore, I'll check when I have time how to fix this, it seems to be now PyIOError but need to test a bit more (IOError use was a bit sloppy at a few places, I need to fix this too (note to self))

EwoutH commented 2 years ago

I replaced all instances of IOError with PyIOError and now the CI passes!

If we merge this PR, we can rebase #7 and try cross compiling again.

@messense I couldn't find that much documentation on the change from exceptions IOError to PyIOError. Is there any and if so could you point me to it?

messense commented 2 years ago

https://pyo3.rs/v0.15.1/migration.html#exception-types-have-been-reworked

EwoutH commented 2 years ago

Thanks! In this PR the PyO3 requirement is also moved from =0.11 to >=0.13, and since the PyErr change happened from PyO3 0.11.* to 0.12, that works out perfectly.

EwoutH commented 2 years ago

On my side this PR is ready for review!

hugoledoux commented 2 years ago

sorry, I am insanely busy and wanted to test a bit more before pressing accept, especially that some students use that these days in one of my course, so don,t want to break it all!

Next week I'll have some time.

EwoutH commented 2 years ago

Thanks for getting back to me, totally fine and testing is important!

You probably know, but this branch can be installed with:

pip install git+https://github.com/EwoutH/startinpy.git@patch-4