search

hugoloza / gwt-mobile-webkit

Automatically exported from code.google.com/p/gwt-mobile-webkit
2 stars 0 forks source link

Fix StorageMap implementation errors, as revealed by the StorageMapTest #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
Run the Storage test on Selenium (e.g. `ant test 
-Dgwt.hosts.web.selenium=localhost:4444/*safari 
-Dgwt.useragents.web.selenium=safari`)

What is the expected output? What do you see instead?
No JUnit failures/errors (from the StorageMapTest testcase)

Original issue reported on code.google.com by bguijt on 25 Jan 2010 at 10:31

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r292.

Original comment by bguijt on 26 Jan 2010 at 12:17

GoogleCodeExporter commented 9 years ago 
A minor note:

Some Java Collection method contracts mandate a `NullPointerException` to be 
thrown if a null argument is 
passed in (e.g. `removeAll()` methods). In GWT we cannot 'throw' 
`NullPointerExceptions`, which is silly 
anyway. 

Whenever a `NullPointerException` is expected, GWT (or rather, JavaScript) is 
throwing a JavaScriptException 
instead.

Thanks to the Google Collections project for providing the Map tests! 
(http://code.google.com/p/google-
collections/source/browse/trunk/testfw/com/google/common/collect/testing/MapInte
rfaceTest.java)

Original comment by bguijt on 26 Jan 2010 at 12:25