search

hugoloza / gwt-platform

Automatically exported from code.google.com/p/gwt-platform
0 stars 0 forks source link

Mavenize the project #211

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Let's go all the way and mavenize the project. We should still try to make it 
easy for anybody to run it in eclipse even if they don't have the Maven plugin 
(which I find is always a headache to install).

Original issue reported on code.google.com by philippe.beaudoin on 22 Sep 2010 at 4:54

GoogleCodeExporter commented 9 years ago 
This is all in trunk now, I have fixed the @Ignore-d tests and made sure it 
works on the CI server (plus we have code coverage! :))

@jgonian: I have modified the custom repository in the POM to work on CI 
server. There was an issue where the CI server interpret ${project.basedir} 
differently than my local machine. On the CI server it seems to correspond to 
the directory of the child project even if it's declared in the base POM. I 
have pushed a workaround for this, but it's a bit ugly. I would love to have 
your opinion and/or a better fix.

Before we close the current issue we still need to:
- Update the documentation on how to build gwtp and how to run/debug it in 
eclipse.
- Make sure build fails on checkstyle error (add a separate issue?)
- Remove AUTHORS file, add them to the main pom.xml
- Automatically build a compound jar for those who don't want all the scattered 
jars. (Is this hard? Should we add a separate issue?)

Also, a related issue I just added, if anybody is interested:
Issue 268: Automatically deploy snapshot to a sonatype repository

Original comment by philippe.beaudoin on 15 Dec 2010 at 9:17

GoogleCodeExporter commented 9 years ago 
This is great! At last, we made it happen. Kudos to everyone!

About the custom repository, I 'd say that we definitely need to get rid of the 
checked in jars (mvnrepo directory) and update our poms prior closing this 
issue. For that, we need to upload the custom dependencies to a public (http) 
repo (this will fix the problem in CI as well). Otherwise, when gwtp-0.5 is 
out, these dependencies will not be able to be resolved as transitive 
dependencies.
See comment 75 (http://code.google.com/p/gwt-platform/issues/detail?id=211#c75 
and in particular http://code.google.com/p/gwt-platform/issues/detail?id=51#c4).
BTW, ${basedir} has been deprecated in maven3.

Re: checkstyle fail on error
This is already done. See in parent pom -> failsOnError.

Re: compound jar
It shouldn't be hard, but I think we should create a different issue for this.

Original comment by jgon...@gmail.com on 15 Dec 2010 at 10:16