hugoloza / gwt-platform

Automatically exported from code.google.com/p/gwt-platform
0 stars 0 forks source link

Boilerplate Generation @GenDispatch - Duplicated constructor in Action class #366

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

Purpose: use @GenDispatch generate Action and Result class for java persistence 
class (e.g. Device)

Here is the code, without any input, simply give all devices:
@GenDispatch
public class GetAllDevices {
    @Out(1) List<Device> devices;
}

What is the expected output? 
... ...
  // expect only one public constructor
  public GetAllDevicesAction() {
  }
... ...

What do you see instead?
... ...
  protected GetAllDevicesAction() {
    // Possibly for serialization.
  }

  public GetAllDevicesAction() {
  }
... ...

What version of the product are you using? On what operating system?
- GWTP-0.7 current trunk, built on 20-Sep-2011
- Win7-64bit with JDK7-64bit
- eclipse 3.7
- google-gin trunk build, google-guice trunk build

Please provide any additional information below.
- I presume this a defect been introduced after 20-Jun-2011.

Original issue reported on code.google.com by b...@bluepoint.net.au on 22 Sep 2011 at 1:53

GoogleCodeExporter commented 9 years ago

Original comment by philippe.beaudoin on 22 Sep 2011 at 2:18

GoogleCodeExporter commented 9 years ago
I made a changeset including some unit tests for this issue: 
http://codereview.appspot.com/5164047/

Feel free to review.

Original comment by bjoern.m...@gmail.com on 2 Oct 2011 at 2:00

GoogleCodeExporter commented 9 years ago
I can confirm this patch
http://codereview.appspot.com/download/issue5164047_1.diff

fixed the issue
http://code.google.com/p/gwt-**platform/issues/detail?id=366<http://code.google.
com/p/gwt-platform/issues/detail?id=366>

Thanks.

-- 
Regards,

Bin Wu | Software Engineer | *BluePoint *| +61 03 9296 5100 | +61 0423 710
288 | *www.bluepoint.net.au* <http://www.bluepoint.net.au/>

BluePoint has Gone *Google*!

*Each day, thousands of companies are going Google by switching to Google
Apps � a web-based suite of messaging and collaboration applications. It's
all hosted by Google, and designed with security and reliability in mind,
saving your company the frustrations and hassles of managing traditional IT
solutions yourself.** Call BluePoint for more information or view the cloud
calculator <http://www.gonegoogle.com> to calculate your potential business
savings.*

Original comment by b...@bluepoint.net.au on 3 Oct 2011 at 12:14

GoogleCodeExporter commented 9 years ago

Original comment by philippe.beaudoin on 1 Feb 2012 at 6:52

GoogleCodeExporter commented 9 years ago
Fixed: goo.gl/TI1Nr

Original comment by FloOn...@gmail.com on 3 Nov 2012 at 11:35