hugoloza / gwt-platform

Automatically exported from code.google.com/p/gwt-platform
0 stars 0 forks source link

Print full call stack when exception were thrown under AbstractDispatchServiceImpl #380

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. throw an exception in any Service/Actionhandler

What is the expected output? What do you see instead?

expect to see the full call stack of the corresponding exception
actual fact: on the exception message were logged

What version of the product are you using? On what operating system?
0.6

Please provide any additional information below.
This is related code:

 @Override
  public Result execute(String cookieSentByRPC, Action<?> action) throws ActionException, ServiceException {

    if (action.isSecured() && !cookieMatch(cookieSentByRPC)) {
      String message = xsrfAttackMessage + " While executing action: " + action.getClass().getName();

      logger.severe(message);
      throw new ServiceException(message);
    }

    try {
      return dispatch.execute(action);
    } catch (ActionException e) {
      logger.warning("Action exception while executing " + action.getClass().getName() + ": " + e.getMessage());
      throw e;
    } catch (ServiceException e) {
      logger.warning("Service exception while executing " + action.getClass().getName() + ": " + e.getMessage());
      throw e;
    } catch (RuntimeException e) {
      logger.warning("Unexpected exception while executing " + action.getClass().getName() + ": " + e.getMessage());
      throw new ServiceException(e);
    }
  }

Original issue reported on code.google.com by tom.fish...@dishcrunch.com on 20 Nov 2011 at 7:00

GoogleCodeExporter commented 9 years ago
on the exception message were logged -> only the exception message were logged

Original comment by tom.fish...@dishcrunch.com on 20 Nov 2011 at 7:01

GoogleCodeExporter commented 9 years ago
Patch welcome!

Original comment by philippe.beaudoin on 24 Nov 2011 at 2:24

GoogleCodeExporter commented 9 years ago
I did a patch for this: http://codereview.appspot.com/5484061/
I'm not sure, if it was thought to be like this (it seemed too easy ;-)), but 
feel free to review ...

Original comment by bjoern.m...@gmail.com on 13 Dec 2011 at 2:43

GoogleCodeExporter commented 9 years ago
Thanks a lot Bjoern. Landed in r34b8ec75fbd6    

Original comment by philippe.beaudoin on 1 Feb 2012 at 2:25