hugomflavio / actel

Standardised analysis of acoustic telemetry data from fish moving through receiver arrays
https://hugomflavio.github.io/actel-website
26 stars 6 forks source link

Don't chop extra columns when parsing detection files / don't use position as column location in processXXXFile() #33

Closed jdpye closed 4 years ago

jdpye commented 4 years ago

In processVemcoFile it assumes that Timestamp will be the first column in a given detection file. Since the files have headers, the processor should take into account whether a person or a format change has moved the column but still labeled it correctly and use the existing location of the column instead.

hugomflavio commented 4 years ago

These seem to be two issues in one:

1) Extra column issue This is done to ensure all subsets of detections have the same columns (regardless of manufacturer/input file). The column set can be expanded, but it would still be hard to just "include all", as each processXXXFile() run has to return a table with the same column names. A possible work-around would be a function argument specifying the names of the non-standard columns the user is interested in. Which columns were you thinking of?

2) Timestamp column in processVemcoFile With commit 6734328, processVemcoFile has been updated to look for the timestamp column using grep("^Date.and.Time", colnames(input))

hugomflavio commented 4 years ago

Using the new preload() function, extra detection columns are no longer ignored