search

hugomrdias / rabin-wasm

Rabin fingerprinting implemented in WASM
28 stars 7 forks source link

Update as-pect and assemblyscript version #5

Open jtenner opened 5 years ago

jtenner commented 5 years ago

A new version of the as-pect cli was released.

Thanks for using as-pect!

hugomrdias commented 5 years ago

Thank you for the PR but i need to update the code to the last assemblyscript version, im still using the old syntax.

jtenner commented 5 years ago

Let me take a look and see if I can help you with that.

jtenner commented 5 years ago

It looks like I can update a lot of your packages and get things installed on my machine, but I have some problems with testing.

I am on a windows machine and cannot run the build binary.

It also looks like the example.imports.js file returns a new Uint8Array which cannot be used. That file returns the reference to be passed into web assembly and will be coerced to an i32 as a result. I moved it into the test itself with a create<T>() function that generates the values for you.

jtenner commented 5 years ago

All set! Please let me know if you have any questions or need help with the latest version of AssemblyScript 🎉

hugomrdias commented 5 years ago

actually can you help me with this https://github.com/ipfs/js-ipfs/issues/2118#issuecomment-497721075 to remove this https://github.com/hugomrdias/rabin-wasm/pull/5/files#diff-1cecc8788b4594868b522b0b733a03d4R49-R52

thank you for your help !!!

jtenner commented 5 years ago

Please forgive me if I don't understand what you're asking for, but I do think that this should cover your needs.

Can you please test this?