search

hugopl / sidekiq.cr

Simple, efficient job processing for Crystal
http://sidekiq.org
GNU Lesser General Public License v3.0
766 stars 74 forks source link

Add ameba on CI and fix several small warnings. #104

Closed hugopl closed 3 years ago

hugopl commented 3 years ago

it also add crystal format --check to CI.

hugopl commented 3 years ago

@mperham ready for review. BTW I am really not sure about when should I just push to the repo and when a proper code review from you is necessary... but I think I could at least always create PRs... and wait few days to see if somebody watching the project do some comments... if nobody says anything I can just merge it.

mperham commented 3 years ago

Yeah, that's a fine policy. @ me so I know the PR is ready and give me 1 business day. If I don't reply by then, merge away.