search

hugopl / sidekiq.cr

Simple, efficient job processing for Crystal
http://sidekiq.org
GNU Lesser General Public License v3.0
766 stars 74 forks source link

Bumps Kemal 1.0.0 -> 1.3.0 #112

Closed hslzr closed 1 year ago

hslzr commented 1 year ago

Out of the box, I encountered the following message after creating a copy of the provided example for web.cr

$ crystal build --release web.cr
Showing last frame. Use --error-trace for full trace.

In lib/kemal/src/kemal/static_file_handler.cr:55:25

 55 | last_modified = modification_time(file_path)
                      ^----------------

It probably has to do with modification_time being a private method?. Anyway, after forking the project and changing Kemal's target version the web UI file compiled without problems.

Might also want to change the instructions, as they instruct to compile it with crystal compile but the new command is crystal build.

mperham commented 1 year ago

I’m not maintaining this repo anymore but I’ll merge simple PRs. If you want the readme updated, you’ll need to do it yourself.