search

hugopl / sidekiq.cr

Simple, efficient job processing for Crystal
http://sidekiq.org
GNU Lesser General Public License v3.0
765 stars 74 forks source link

Compatability with 0.36.1 #87

Closed kalinon closed 3 years ago

kalinon commented 4 years ago

This will be needed for compatibility for 0.34.0. However some kemal/sessions will need to be updated before this cspec can be fixed.

kalinon commented 4 years ago

Ive added some more commits to this PR to be compatible with building with preview_mt. I subbed out the pooling code to use DB::Pool which is thread safe.

n-rodriguez commented 3 years ago

Hi there! Any news?

kalinon commented 3 years ago

Pulled in suggestions from @Sija and @n-rodriguez (Thanks!). Updated deps and code to work with 0.36.1

hugopl commented 3 years ago

I'm using this branch from @xaviablaza and it works.

mperham commented 3 years ago

Hi folks, I don't support this project anymore which means I ignore this repo and all comments until someone explicitly @'s me and politely asks me to merge. This is all it takes:

Hey @mperham, this is ready to go.

I would also be happy to see more maintainers; folks who want commit access so they can maintain this repo without me. If the Crystal community wants to fork the project and take over, that's fine -- I would just ask that the project name be changed. Sidekiq is me and I don't want others to be confused.

I also block people who add toxic commentary. Don't bring sarcasm, hostility or passive aggression into my repos. Thank you.

hugopl commented 3 years ago

@xaviablaza, would you mind in create a new PR with your changes? Since we don't know if the original author of this PR still on this.

I could create the PR too, but better have the original patch authors doing this.

IMO keeping the project here with non official support status and more maintainers that can approve/merge stuff bring more visibility than create a fork with a different name, so this would be better for both, Sidekiq and Crystal.

xaviablaza commented 3 years ago

I can do that this weekend.

On Wed, Mar 17, 2021, 10:26 Hugo Parente Lima @.***> wrote:

@xaviablaza https://github.com/xaviablaza, would you mind in create a new PR with your changes? Since we don't know if the original author of this PR still on this.

I could create the PR too, but better have the original patch authors doing this.

IMO keeping the project here with non official support status and more maintainers that can approve/merge stuff bring more visibility than create a fork with a different name, so this would be better for both, Sidekiq and Crystal.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mperham/sidekiq.cr/pull/87#issuecomment-801267272, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGBUBFVLAWFC5CAVBAKLE6DTEDQWJANCNFSM4MXLDAYA .

marcoroth commented 3 years ago

@mperham maybe it would make sense to mention the current status of the project in the README or in a dedicated "looking for maintainers" issue.

hugopl commented 3 years ago

I can do that this weekend.

I just noticed that the tests still failing, so if you don't mind I'll try to take a look too.

hugopl commented 3 years ago

Closing this, since https://github.com/mperham/sidekiq.cr/pull/92 got merged.