Fix regression on retry jobs after a4b6384220256704d1b045bea057dbdd00ca6f0d

hugopl / sidekiq.cr

Simple, efficient job processing for Crystal

http://sidekiq.org

GNU Lesser General Public License v3.0

766 stars 74 forks source link

Fix regression on retry jobs after a4b6384220256704d1b045bea057dbdd00ca6f0d #99

Closed hugopl closed 3 years ago

hugopl commented 3 years ago

Correctly set retried_at and failed_at fields.
Add timecop development dependency to test job retries.

Issue found at https://github.com/mperham/sidekiq.cr/commit/a4b6384220256704d1b045bea057dbdd00ca6f0d#r48541525

mperham commented 3 years ago

You can merge your own bug fixes, I don't mind.

hugopl commented 3 years ago

Are you fine with me tagging v0.7.0 soon after https://github.com/mperham/sidekiq.cr/issues/91 gets fixed?

mperham commented 3 years ago

Sure

On Mon, Mar 22, 2021 at 10:49 Hugo Parente Lima @.***> wrote:

Are you fine with me tagging v0.7.0 soon after #91 https://github.com/mperham/sidekiq.cr/issues/91 gets fixed?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/mperham/sidekiq.cr/pull/99#issuecomment-804267605, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAWXZUD4W4664NVZ56YSTTE57MFANCNFSM4ZTGCG6A .