hugosaintemarie / magic-maze

Online version of board game "Magic Maze"
https://magicmaze.herokuapp.com
MIT License
20 stars 11 forks source link

Game manual? #12

Closed borgeser closed 4 years ago

borgeser commented 4 years ago

Hi ashugeo and thank you for this game!

I had a hard time figuring out how to add a new tile. A short manual with the keyboard shortcuts would be very appreciated :)

I was also wondering: what is the status of this project? Is the game fully implemented or are some rules missing? Do you plan to work on it anymore?

I'm not an experienced web developer but I will definitely spend some time in order to understand your code and see if I can add some features.

Regards,

A French compatriote.

hugosaintemarie commented 4 years ago

Hello @borgeser 👋

This game is a little side-project of mine that I've started working on a couple years ago when a friend made me discover the board game. I hadn't worked on it for a while, but then recently with the lockdown I decided to continue working on it! I'm not an experienced web developer either but I learn new stuff with this kind of projects!

Currently as you'll see in dev branch, I'm working on dropping p5.js and using pure SVG instead to draw the board and other items. I haven't yet worked on UX features, user onboarding and such. Not all rules (scenarios) are implemented yet (for instance role swap is commented out currently). I am looking forward to adding them! Also I need to clean up a lot of mess, and improve some parts with new stuff I've learnt for the past couple years!

I haven't yet communicated around this project (but you found me 👀) because I think at this point it's a bit of a copyright infringement towards Sit Down! games. I still have to figure it out and maybe ask them for some kind of permission, I really don't wanna do this the wrong way. This is also the reason why I haven't made it "easy to understand" so far.

Here's a list of controls currently in use in the master branch version:

borgeser commented 4 years ago

Thank you for your answer.

May I know why you are planning removing p5.js?

I've browsed your project and here are some tips:

You won't need to delete a lot of code, just to move the code on appropriate files. Nevertheless your code is clear and easy to follow.

I'd be glad to help but I don't want to conflict with your refactoring. If you are interested by some of my suggestions or help in any way, you can contact me by email.

hugosaintemarie commented 4 years ago

Hello again @borgeser,

I'm removing p5.js to improve performance, and get rid of a lib. Also it will fix an issue with the minified version of p5.js which is actually not minified.

Thank you so much for your tips! This sounds complex to me but I'll make sure to get in touch when I think of improving the overall structure like you suggested. 🙏