hugosenari / Kupfer-Plugins

My kupfer plugins install with Kupfer
https://github.com/kupferlauncher/kupfer/
11 stars 2 forks source link

Remmina Plugins doesn't work #4

Closed khurshid-alam closed 7 years ago

khurshid-alam commented 7 years ago

I was trying to use your remmina plugin, but it doesn't any show any host. It can only execute remmina app itself.

How does it suppose to work?

hugosenari commented 7 years ago

Thank you for fill this issue. 👍

You can have these problems:

Maybe this is good to include in a FAQ 😄

khurshid-alam commented 7 years ago

Plugin can't find your saved hosts verify if directory defined at plugin's preference contains your data (*.remmina)

It's that. Remmina configuration is saved under /home/$USER/.remmina. May be you want to make that default.

hugosenari commented 7 years ago

According to remmina source code:

Since they define ~/.remmina as 'legacy', I wont make it default. Maybe search for both. What you think?

khurshid-alam commented 7 years ago

Maybe search for both. What you think?

Yes. Search for both location would be nice. :)

offtopic: I think this should go on upstream. Can you open a PR at https://github.com/KarolBedkowski/kupfer-adds (which is the new upstream) ?

Only adding remmina.py in kupfer/plugin (https://github.com/KarolBedkowski/kupfer-adds/tree/master/kupfer/plugin) should be enough. Thanks.

hugosenari commented 7 years ago

To be honest I would be happy if they accept my plugin at theirs main code.

But I don't think this is the correct answer, we need a marketplace for plugin.

Anyway I tried make install process frictionless with pip:

pip install kupfer_plugin_remmina

You don't need sudo since they only copy file to ~/.local/share/kupfer/plugin

Hoping that other developers could do the same, I created a cookiecutter to help them.

Maybe a plugin where user can search and install plugins from kupfer would be good idea :smile:

hugosenari commented 7 years ago

Almost there, now I need know how to donwload, unpack and 'install' plugins to have a proper marketplace.