hugovk / norwegianblue

CLI to show end-of-life dates for a number of products.
https://endoflife.date
MIT License
76 stars 4 forks source link

termcolor now disables colour if not tty, but FORCE_COLOR for colour tests #107

Closed hugovk closed 1 year ago

hugovk commented 1 year ago

Since https://github.com/termcolor/termcolor/releases/tag/2.1.0 and https://github.com/termcolor/termcolor/pull/25, we need to make sure colour is enabled for these tests.

Fixes failures seen in https://github.com/hugovk/norwegianblue/pull/103, https://github.com/hugovk/norwegianblue/pull/104, https://github.com/hugovk/norwegianblue/pull/105, https://github.com/hugovk/norwegianblue/pull/106.

codecov[bot] commented 1 year ago

Codecov Report

Merging #107 (90f9d95) into main (45159d6) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   95.28%   95.30%   +0.01%     
==========================================
  Files           9        9              
  Lines         382      383       +1     
==========================================
+ Hits          364      365       +1     
  Misses         18       18              
Flag Coverage Δ
macos-latest 94.77% <100.00%> (-0.51%) :arrow_down:
ubuntu-latest 95.30% <100.00%> (+0.01%) :arrow_up:
windows-latest 95.30% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_norwegianblue.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more