search

hugovk / norwegianblue

CLI to show end-of-life dates for a number of products.
https://endoflife.date
MIT License
74 stars 4 forks source link

Add explicit dependency for importlib-metadata on 3.7 #122

Closed hugovk closed 1 year ago

hugovk commented 1 year ago

It was being implicitly installed via tox on the CI:

Collecting tox
  Downloading tox-4.1.3-py3-none-any.whl (145 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 145.1/145.1 kB 3.7 MB/s eta 0:00:00
Collecting virtualenv>=[20](https://github.com/hugovk/norwegianblue/actions/runs/3827457817/jobs/6512055680#step:4:21).17.1
  Using cached virtualenv-20.17.1-py3-none-any.whl (8.8 MB)
Collecting filelock>=3.9
  Using cached filelock-3.9.0-py3-none-any.whl (9.7 kB)
Collecting cachetools>=5.2
  Using cached cachetools-5.2.0-py3-none-any.whl (9.3 kB)
Collecting pluggy>=1
  Using cached pluggy-1.0.0-py2.py3-none-any.whl (13 kB)
Collecting colorama>=0.4.6
  Using cached colorama-0.4.6-py2.py3-none-any.whl (25 kB)
Collecting platformdirs>=2.6.2
  Using cached platformdirs-2.6.2-py3-none-any.whl (14 kB)
Collecting tomli>=2.0.1
  Using cached tomli-2.0.1-py3-none-any.whl (12 kB)
Collecting importlib-metadata>=5.2
  Downloading importlib_metadata-6.0.0-py3-none-any.whl ([21](https://github.com/hugovk/norwegianblue/actions/runs/3827457817/jobs/6512055680#step:4:22) kB)
Collecting chardet>=5.1
  Using cached chardet-5.1.0-py3-none-any.whl (199 kB)
Collecting packaging>=[22](https://github.com/hugovk/norwegianblue/actions/runs/3827457817/jobs/6512055680#step:4:23)
  Using cached packaging-22.0-py3-none-any.whl (42 kB)
Collecting typing-extensions>=4.4
  Using cached typing_extensions-4.4.0-py3-none-any.whl ([26](https://github.com/hugovk/norwegianblue/actions/runs/3827457817/jobs/6512055680#step:4:27) kB)
Collecting pyproject-api>=1.2.1
  Using cached pyproject_api-1.2.1-py3-none-any.whl (11 kB)
Collecting zipp>=0.5
  Using cached zipp-3.11.0-py3-none-any.whl (6.6 kB)
Collecting distlib<1,>=0.3.6
  Using cached distlib-0.3.6-py2.py3-none-any.whl ([46](https://github.com/hugovk/norwegianblue/actions/runs/3827457817/jobs/6512055680#step:4:47)8 kB)

Instead, depend on it explicitly to make sure it's installed.

Missed in https://github.com/hugovk/norwegianblue/pull/94.

codecov[bot] commented 1 year ago

Codecov Report

Merging #122 (b647cd4) into main (2bc3f26) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files           9        9           
  Lines         392      392           
=======================================
  Hits          374      374           
  Misses         18       18
Flag Coverage Δ
macos-latest 95.40% <ø> (ø)
ubuntu-latest 95.40% <ø> (ø)
windows-latest 95.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more