hugovk / norwegianblue

CLI to show end-of-life dates for a number of products.
https://endoflife.date
MIT License
76 stars 4 forks source link

Refactor cache stuff into module #68

Closed hugovk closed 2 years ago

hugovk commented 2 years ago

Also replace verbose prints with logging, and add some typing, some via https://github.com/JelleZijlstra/autotyping.

codecov[bot] commented 2 years ago

Codecov Report

Merging #68 (82a917c) into main (bb5d859) will decrease coverage by 0.94%. The diff coverage is 92.15%.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   96.69%   95.75%   -0.95%     
==========================================
  Files           8        8              
  Lines         363      353      -10     
==========================================
- Hits          351      338      -13     
- Misses         12       15       +3     
Flag Coverage Δ
GHA_Ubuntu 95.75% <92.15%> (-0.95%) :arrow_down:
GHA_Windows 95.75% <92.15%> (-0.95%) :arrow_down:
GHA_macOS 95.75% <92.15%> (-0.95%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/norwegianblue/cli.py 0.00% <0.00%> (ø)
src/norwegianblue/__init__.py 98.44% <83.33%> (+1.35%) :arrow_up:
src/norwegianblue/_cache.py 94.11% <94.11%> (ø)
tests/test_cache.py 100.00% <100.00%> (ø)
tests/test_norwegianblue.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb5d859...82a917c. Read the comment docs.

hugovk commented 2 years ago

The coverage "drop" is because we've deleted a file of code.

Looking at the deltas of the remaining files, they're either the same or have increased.