Closed GoogleCodeExporter closed 9 years ago
Thanks for the analysis.
Original comment by baron.schwartz
on 24 Nov 2008 at 12:07
Target these for release end of January 2009.
Original comment by baron.schwartz
on 4 Jan 2009 at 5:04
I'm working on this.
Original comment by dan...@percona.com
on 6 Jan 2009 at 7:19
I've fixed this but the fix is causing other tests to break so I'm not
committing it
yet. I think there may be a problem in TableNibbler::generate_ins_stmt()--that
or I'm
not clear on what the return value of this sub is supposed to be. I'll find
this out
tomorrow. In any case, I've isolated the problem and know how to fix it, but I
need a
better understanding of some other stuff first.
Original comment by dan...@percona.com
on 7 Jan 2009 at 1:47
r2738 and r2784 have work in progress. r2738 fixes
TableNibbler::generate_ins_stmt()
to what I think it was meant to do, and r2784 implements it in mk-archiver
which does
then fix my test for this issue. But it also breaks an older test. I'm inclined
to
believe that my updates and new test are correct, and that old test which is
breaking
is wrong/showing us that there's another issue to fix somewhere. Further
investigation will reveal what's wrong.
Original comment by dan...@percona.com
on 7 Jan 2009 at 1:17
This should be fixed in r2785 but, Baron, you should double check this. I
marked the
test case (you'll see it in the diff) which I changed because I'm sure it was
wrong.
You'll also want to see how I changed TableNibbler::generate_ins_stmt(). I
added more
documentation to that sub to explain what I'm doing and why.
I'll leave this issue open. If you agree with the changes, we'll mark this as
Fixed.
Original comment by dan...@percona.com
on 7 Jan 2009 at 6:24
In my comment 5 I have a typo: r2738 should be r2783.
Original comment by dan...@percona.com
on 17 Jan 2009 at 9:14
I believe this issue is fixed now.
Original comment by baron.schwartz
on 31 Jan 2009 at 3:27
Original comment by baron.schwartz
on 30 Jan 2010 at 5:13
Original issue reported on code.google.com by
shalomsh...@gmail.com
on 20 Nov 2008 at 8:42