Closed h4ckd0tm3 closed 1 year ago
Thanks @h4ckd0tm3 ! Looks great but I'll need a bit of time to review, but I'll get on it @lanjelot if you happen to have some spare time too, go for it 😉
Hey @h4ckd0tm3
I just saw this PR includes the changes from your 1st PR (#59)
You might want to change the target destination for the merge of this PR to your branch of the first PR (h4ckd0tm3:master
). This way this PR will only include the changes specific to this PR, and not your entire work.
Cheers
Hey @h4ckd0tm3
I just saw this PR includes the changes from your 1st PR (#59)
You might want to change the target destination for the merge of this PR to your branch of the first PR (
h4ckd0tm3:master
). This way this PR will only include the changes specific to this PR, and not your entire work.Cheers
I cannot change the repository of the PR only the branch, so I guess I would have to close this one and make a new one? Sorry again, not a lot experience with PR's ^^'
I cannot change the repository of the PR only the branch, so I guess I would have to close this one and make a new one? Sorry again, not a lot experience with PR's ^^'
No problem, yeah feel free to close and re-open 😄
As mentioned in #64