hugsy / gef-extras

Extra goodies for GEF to (try to) make GDB suck even less
https://hugsy.github.io/gef-extras
MIT License
148 stars 50 forks source link

fix path syscall-args search #107

Closed therealdreg closed 2 months ago

therealdreg commented 2 months ago

Description/Motivation/Screenshots

fix syscall-args path search

How Has This Been Tested ?

"Tested" indicates that the PR works and the unit test (i.e. make test) run passes without issue.

Checklist

hugsy commented 2 months ago

From @therealdreg

Repro:

root@fr33project:~# bash -c "$(curl -fsSL https://gef.blah.cat/sh)"
root@fr33project:~# wget -q -O- https://github.com/hugsy/gef/raw/main/scripts/gef-extras.sh | sh

image

Re-posting reply here for tracking:

I could reproduce your issue. there is a problem, but your PR doesn't solve it, it 's just a side effect of it. the problem is that the setting is overwritten by its default value when it shouldn't be basically all values are overwritten by their default tbh that may be tricky to solve quickly, so what I'd suggest you is simply make a gef restore to force reloading the .gef.rc

This PR fixes the visible side-effect rather than the root cause of the issue. One possible way to address this would be to force gef restore once the setting gef.extra_plugins_dir is changed to a different value. This will fix the issue this PR tries to fix, because the setting is originally correctly set by the gef-extras.sh install script.

therealdreg commented 2 months ago

thx for your research @hugsy