retdec does not decompile binary from path that contains a space

[khaoticdude]

• [x] Did you use the latest version of GEF from dev branch?
• [x] Is your bug specific to GEF (not GDB)? - Try to reproduce it running gdb -nx
• [x] Did you read the documentation first?
• [x] Did you check issues (including the closed ones) - and the PR?

Step 1: Describe your environment

• Operating System / Distribution: Kali
• Architecture: x86_64
• GEF version (including the Python library version) run version in GEF. GEF: rev:10d0086c09a1505d6c63b436fcb6f2422518313c (Git - clean) SHA1(/opt/GEF/gef/gef.py): 4deed06807f24ac47b3d1fe3370b9f6f80dde3dc GDB: 10.1.90.20210103-git GDB-Python: 3.9

Step 2: Describe your problem

The decompile -a command does not appear to handle the path to the binary well

Steps to reproduce

1. Try to decompile a binary that is within a path with spaces

This "canary" binary is located at: "/home/khaotic/labs/Linux Exploit Development/Test_Linux_Program/"

[khaoticdude]

Just realized I posed on the wrong repo and not the get-extras one. Should I reopen it there?

[hugsy]

Just realized I posed on the wrong repo and not the get-extras one. Should I reopen it there?

Done.

Also I've never used this plugin, I'll let someone who has help you out.

[hugsy]

At first sight, it looks like an easy bug to fix: in https://github.com/hugsy/gef-extras/blob/master/scripts/retdec.py#L94 try replacing:

fname = "{}/{}.{}".format(path, os.path.basename(params["input_file"]), params["target_language"])

with

fname = "'{}/{}.{}'".format(path, os.path.basename(params["input_file"]), params["target_language"])

[khaoticdude]

That did not fix the issue.

[Grazfather]

This is an easy fix, but I am not in a position to fix/test right now.

Do you know python? You just need to use shlex.quote on the fname when building the command, but NOT until after line 105, though the proper solution would be to not use shell=True in the subprocess invocation.

[hugsy]

See PR #33